-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minor issues with small tests #4147
Conversation
It was flaky, because a new test case could start before the previous supervisor was shut down, leading to flaky failures.
The tests were skipped because 'localhost' was resolved to an IPv6 address, and connection failed.
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / f0173c0 small_tests_25 / small_tests / f0173c0 small_tests_26_arm64 / small_tests / f0173c0 small_tests_26 / small_tests / f0173c0 ldap_mnesia_25 / ldap_mnesia / f0173c0 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / f0173c0 ldap_mnesia_26 / ldap_mnesia / f0173c0 dynamic_domains_mysql_redis_26 / mysql_redis / f0173c0 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / f0173c0 internal_mnesia_26 / internal_mnesia / f0173c0 pgsql_mnesia_25 / pgsql_mnesia / f0173c0 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / f0173c0 pgsql_cets_26 / pgsql_cets / f0173c0 mysql_redis_26 / mysql_redis / f0173c0 mssql_mnesia_26 / odbc_mssql_mnesia / f0173c0 pgsql_mnesia_26 / pgsql_mnesia / f0173c0 |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4147 +/- ##
==========================================
+ Coverage 84.04% 84.05% +0.01%
==========================================
Files 561 561
Lines 34050 34050
==========================================
+ Hits 28617 28621 +4
+ Misses 5433 5429 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiiiiiice 🔥
acl_SUITE
ejabberd_sm_SUITE