Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issues with small tests #4147

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix minor issues with small tests #4147

merged 2 commits into from
Oct 12, 2023

Conversation

chrzaszcz
Copy link
Member

  • Resolve flaky test in acl_SUITE
  • Don't skip redis tests in ejabberd_sm_SUITE

It was flaky, because a new test case could start before the previous
supervisor was shut down, leading to flaky failures.
The tests were skipped because 'localhost' was resolved to an IPv6
address, and connection failed.
@chrzaszcz chrzaszcz changed the title Fix minor issue with small tests Fix minor issues with small tests Oct 12, 2023
@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 12, 2023

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / f0173c0
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_25 / small_tests / f0173c0
Reports root / small


small_tests_26_arm64 / small_tests / f0173c0
Reports root / small


small_tests_26 / small_tests / f0173c0
Reports root / small


ldap_mnesia_25 / ldap_mnesia / f0173c0
Reports root/ big
OK: 2303 / Failed: 0 / User-skipped: 865 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / f0173c0
Reports root/ big
OK: 4268 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / f0173c0
Reports root/ big
OK: 2303 / Failed: 0 / User-skipped: 865 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / f0173c0
Reports root/ big
OK: 4236 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / f0173c0
Reports root/ big
OK: 4268 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / f0173c0
Reports root/ big
OK: 2453 / Failed: 0 / User-skipped: 715 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / f0173c0
Reports root/ big
OK: 4657 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / f0173c0
Reports root/ big
OK: 4265 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / f0173c0
Reports root/ big
OK: 4655 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / f0173c0
Reports root/ big
OK: 4637 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / f0173c0
Reports root/ big
OK: 4654 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / f0173c0
Reports root/ big
OK: 4657 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (51dbdd1) 84.04% compared to head (f0173c0) 84.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4147      +/-   ##
==========================================
+ Coverage   84.04%   84.05%   +0.01%     
==========================================
  Files         561      561              
  Lines       34050    34050              
==========================================
+ Hits        28617    28621       +4     
+ Misses       5433     5429       -4     

see 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrzaszcz chrzaszcz marked this pull request as ready for review October 12, 2023 11:04
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiiiiice 🔥

@NelsonVides NelsonVides merged commit 4e5291b into master Oct 12, 2023
4 checks passed
@NelsonVides NelsonVides deleted the fix-small-tests branch October 12, 2023 11:29
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants