Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymous auth supports mnesia and cets backends #4148

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

NelsonVides
Copy link
Collaborator

@NelsonVides NelsonVides commented Oct 12, 2023

MIM-2066
ejabberd_auth_anonymous has now two backends, mnesia and cets, which can be configured.

@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (c858cec) 83.82% compared to head (6c27108) 84.04%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4148      +/-   ##
==========================================
+ Coverage   83.82%   84.04%   +0.21%     
==========================================
  Files         561      564       +3     
  Lines       34053    34083      +30     
==========================================
+ Hits        28546    28645      +99     
+ Misses       5507     5438      -69     
Files Coverage Δ
src/auth/ejabberd_auth_anonymous_backend.erl 90.90% <90.90%> (ø)
src/auth/ejabberd_auth_anonymous_mnesia.erl 87.50% <87.50%> (ø)
src/auth/ejabberd_auth_anonymous.erl 64.91% <75.00%> (-3.95%) ⬇️
src/auth/ejabberd_auth_anonymous_cets.erl 73.33% <73.33%> (ø)

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NelsonVides NelsonVides force-pushed the cets/auth_anonymous branch 2 times, most recently from 235019c to fd682c5 Compare October 17, 2023 08:46
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@NelsonVides NelsonVides changed the title Move anonymous auth mnesia table into cets Anonymous auth supports mnesia and cets backends Oct 17, 2023
@NelsonVides NelsonVides marked this pull request as ready for review October 17, 2023 12:27
@NelsonVides NelsonVides marked this pull request as draft October 17, 2023 12:39
@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 17, 2023

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 6c27108
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_25 / small_tests / 6c27108
Reports root / small


small_tests_26 / small_tests / 6c27108
Reports root / small


small_tests_26_arm64 / small_tests / 6c27108
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 6c27108
Reports root/ big
OK: 2307 / Failed: 0 / User-skipped: 865 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 6c27108
Reports root/ big
OK: 2307 / Failed: 0 / User-skipped: 865 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 6c27108
Reports root/ big
OK: 4240 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6c27108
Reports root/ big
OK: 4272 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 6c27108
Reports root/ big
OK: 4272 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 6c27108
Reports root/ big
OK: 4269 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 6c27108
Reports root/ big
OK: 4641 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 6c27108
Reports root/ big
OK: 2457 / Failed: 0 / User-skipped: 715 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 6c27108
Reports root/ big
OK: 4661 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 6c27108
Reports root/ big
OK: 4659 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 6c27108
Reports root/ big
OK: 4661 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 6c27108
Reports root/ big
OK: 4658 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

@NelsonVides NelsonVides marked this pull request as ready for review October 17, 2023 20:33
Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@arcusfelis arcusfelis merged commit f989a92 into master Oct 19, 2023
3 of 4 checks passed
@arcusfelis arcusfelis deleted the cets/auth_anonymous branch October 19, 2023 06:45
Copy link
Collaborator

@DenysGonchar DenysGonchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants