Remove legacy CLI commands

[jacekwegr]

This pull request removes outdated command-line interface commands, along with their associated configuration options and tests. Additionally, it removes the mnesia command when executed without arguments, as its functionality is already covered by the systemInfo command.

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (07c2263) 84.03% compared to head (d51f4fc) 84.29%.
Report is 4 commits behind head on master.

Files	Patch %	Lines
src/ejabberd_ctl.erl	90.62%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4160      +/-   ##
==========================================
+ Coverage   84.03%   84.29%   +0.26%     
==========================================
  Files         564      550      -14     
  Lines       34064    33413     -651     
==========================================
- Hits        28625    28165     -460     
+ Misses       5439     5248     -191     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chrzaszcz]

Nice to see the all the cleanup. The main issue I see is that some commands were partially removed, e.g. mongooseimctl still has a lot of scripting around commands like join_cluster. Furthermore, removal of such commands would break our Docker and Helm installations. Finally, these commands were not clearly marked as deprecated. Details in comments.

[chrzaszcz]

Looks really good 👍

[chrzaszcz]

A few minor comments from me

[mongoose-im]

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / d51f4fc
Reports root/ big
OK: 368 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

---

small_tests_25 / small_tests / d51f4fc
Reports root / small

---

small_tests_26 / small_tests / d51f4fc
Reports root / small

---

small_tests_26_arm64 / small_tests / d51f4fc
Reports root / small

---

ldap_mnesia_25 / ldap_mnesia / d51f4fc
Reports root/ big
OK: 2267 / Failed: 0 / User-skipped: 839 / Auto-skipped: 0

---

dynamic_domains_mysql_redis_26 / mysql_redis / d51f4fc
Reports root/ big
OK: 4183 / Failed: 0 / User-skipped: 135 / Auto-skipped: 0

---

ldap_mnesia_26 / ldap_mnesia / d51f4fc
Reports root/ big
OK: 2267 / Failed: 0 / User-skipped: 839 / Auto-skipped: 0

---

dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / d51f4fc
Reports root/ big
OK: 4216 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

---

pgsql_cets_26 / pgsql_cets / d51f4fc
Reports root/ big
OK: 4264 / Failed: 0 / User-skipped: 110 / Auto-skipped: 0

---

internal_mnesia_26 / internal_mnesia / d51f4fc
Reports root/ big
OK: 2407 / Failed: 0 / User-skipped: 699 / Auto-skipped: 0

---

dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / d51f4fc
Reports root/ big
OK: 4212 / Failed: 1 / User-skipped: 105 / Auto-skipped: 0

muc_SUITE:register:user_submits_registration_form_twice

{error,
  {{assertion_failed,assert,is_iq_result,
     [{xmlel,<<"iq">>,
        [{<<"type">>,<<"set">>},
         {<<"id">>,<<"4fd3318a89013a6160c6e688035cfb19">>},
         {<<"to">>,<<"groupchats.domain.example.com">>}],
        [{xmlel,<<"query">>,
           [{<<"xmlns">>,<<"jabber:iq:register">>}],
           [{xmlel,<<"x">>,
            [{<<"xmlns">>,<<"jabber:x:data">>},
             {<<"type">>,<<"submit">>}],
            [{xmlel,<<"field">>,
               [{<<"type">>,<<"hidden">>},
                {<<"var">>,<<"FORM_TYPE">>}],
               [{xmlel,<<"value">>,[],
                  [{xmlcdata,<<"jabber:iq:register">>}]}]},
             {xmlel,<<"field">>,
               [{<<"type">>,<<"text-single">>},
                {<<"var">>,<<"nick">>}],
               [{xmlel,<<"value">>,[],
                  [{xmlcdata,
                     <<"thirdwitchroom-a56e1ea50d">>}]}]}]}]}]}],
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"groupchats.domain.example.com">>},
        {<<"to">>,
         <<"alice_user_submits_registration_form_twice_2611@domain.example.com/res1">>},
        {<<"type">>,<<"error">>},
        {<<"id">>,<<"4fd3318a89013a6160c6e688035cfb19">>}],
       [{xmlel,<<"query">>,
          [{<<"xmlns">>,<<"jabber:iq:register">>}],
          [{xmlel,<<"x">>,
             [{<<"xmlns">>,<<"jabber:x:data">>},
            {<<"type">>,<<"submit">>}],
             [{xmlel,<<"field">>,
              [{<<"type">>,<<"hidden">>},
               {<<"var">>,<<"FORM_TYPE">>}],
...

Report log

---

pgsql_mnesia_25 / pgsql_mnesia / d51f4fc
Reports root/ big
OK: 4605 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0

---

pgsql_mnesia_26 / pgsql_mnesia / d51f4fc
Reports root/ big
OK: 4605 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0

---

mysql_redis_26 / mysql_redis / d51f4fc
Reports root/ big
OK: 4584 / Failed: 0 / User-skipped: 130 / Auto-skipped: 0

---

mssql_mnesia_26 / odbc_mssql_mnesia / d51f4fc
Reports root/ big
OK: 4602 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

graphql_muc_light_SUITE:admin_cli:admin_muc_light:end_per_group

{error,
 {{unregistering_failed,
   {amount,1},
   {unregistered_items,
  [{{<<"_admin_delete_room_1126">>,
     [{escalus_event_mgr,<0.24524.0>},
    {tc_name,admin_delete_room},
    {escalus_cleaner,<0.24523.0>},
    {watchdog,<0.24522.0>},
    {muc_light_host,<<"muclight.localhost">>},
    {secondary_muc_light_host,<<"muclight.localhost.bis">>},
    {protocol,cli},
    {schema_endpoint,admin},
    {{ejabberd_cwd,mongooseim@localhost},
     "/home/circleci/project/_build/mim1/rel/mongooseim"},
    {preset,"odbc_mssql_mnesia"},
    {mim_data_dir,
     "/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
    {tc_logfile,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4160/200780/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40a2158090244d.2023-11-24_08.05.14/big_tests.tests.graphql_muc_light_SUITE.logs/run.2023-11-24_08.09.50/graphql_muc_light_suite.admin_delete_room.43651.html"},
    {tc_group_properties,[{name,admin_muc_light}]},
    {tc_group_path,[[{name,admin_cli}]]},
    {data_dir,
     "/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
    {priv_dir,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4160/200780/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40a2158090244d.2023-11-24_08.05.14/big_tests.tests.graphql_muc_light_SUITE.logs/run.2023-11-24_08.09.50/log_private/"},
    {{saved_modules,mongooseim@localhost,<<"localhost">>},
     #{mod_vcard =>
      #{matches => 30,
        host => {prefix,<<"vjud.">>},
        search => true,backend => rdbms,iqdisc => parallel},
       mod_roster ...

Report log

---

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d51f4fc
Reports root/ big
OK: 4216 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

---

dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / d51f4fc
Reports root/ big
OK: 4213 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

[chrzaszcz]

👌