Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unavailableNodes list having joined nodes #4185

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

arcusfelis
Copy link
Contributor

@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 4, 2023

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 2b237b1
Reports root/ big
OK: 368 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_25 / small_tests / 2b237b1
Reports root / small


small_tests_26 / small_tests / 2b237b1
Reports root / small


small_tests_26_arm64 / small_tests / 2b237b1
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 2b237b1
Reports root/ big
OK: 2268 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 2b237b1
Reports root/ big
OK: 4192 / Failed: 0 / User-skipped: 135 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 2b237b1
Reports root/ big
OK: 4225 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 2b237b1
Reports root/ big
OK: 2268 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 2b237b1
Reports root/ big
OK: 4224 / Failed: 1 / User-skipped: 102 / Auto-skipped: 0

sm_SUITE:ping_timeout
{error,
  {{assertion_failed,assert,is_presence,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"domain.example.com">>},
        {<<"to">>,
         <<"[email protected]/escalus-default-resource">>},
        {<<"type">>,<<"get">>},
        {<<"id">>,<<"489272e2fd0f3427">>}],
       [{xmlel,<<"ping">>,[{<<"xmlns">>,<<"urn:xmpp:ping">>}],[]}]},
     "<iq from='domain.example.com' to='[email protected]/escalus-default-resource' type='get' id='489272e2fd0f3427'><ping xmlns='urn:xmpp:ping'/></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {sm_helper,initial_presence_step,2,
      [{file,"/home/circleci/project/big_tests/tests/sm_helper.erl"},
       {line,135}]},
    {escalus_connection,connection_step,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
       {line,163}]},
    {lists,foldl_1,3,[{file,"lists.erl"},{line,1599}]},
    {escalus_connection,start,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
       {line,145}]},
    {sm_helper,connect_spec,3,
      [{file,"/home/circleci/project/big_tests/tests/sm_helper.erl"},
       {line,153}]},
    {sm_SUITE,ping_timeout,1,
      [{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
       {line,625}]},
    {...

Report log


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 2b237b1
Reports root/ big
OK: 4222 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 2b237b1
Reports root/ big
OK: 4614 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 2b237b1
Reports root/ big
OK: 4272 / Failed: 1 / User-skipped: 110 / Auto-skipped: 0

bosh_SUITE:chat:interleave_requests
{error,
  {{badmatch,
     {error,
       {connection_step_failed,
         {{escalus_session,stream_features},
          {client,<<"carol@localhost/bosh">>,escalus_bosh,<0.7349.0>,
            undefined,
            [{event_client,
               [{event_manager,<0.7346.0>},
              {server,<<"localhost">>},
              {username,<<"carol">>},
              {resource,<<"bosh">>}]},
             {resource,<<"bosh">>},
             {username,<<"carol">>},
             {server,<<"localhost">>},
             {host,<<"localhost">>},
             {port,5280},
             {auth,{escalus_auth,auth_plain}},
             {wspath,undefined},
             {keepalive,false},
             {username,<<"carol">>},
             {server,<<"localhost">>},
             {password,<<"jinglebells">>},
             {transport,escalus_bosh},
             {path,<<"/http-bind">>},
             {port,5280}]},
          []},
         {timeout,wait_for_features}}}},
   [{bosh_SUITE,start_client,3,
      [{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
       {line,856}]},
    {bosh_SUITE,'-interleave_requests/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
       {line,350}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{f...

Report log


internal_mnesia_26 / internal_mnesia / 2b237b1
Reports root/ big
OK: 2408 / Failed: 0 / User-skipped: 707 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 2b237b1
Reports root/ big
OK: 4614 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 2b237b1
Reports root/ big
OK: 4593 / Failed: 0 / User-skipped: 130 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 2b237b1
Reports root/ big
OK: 4609 / Failed: 2 / User-skipped: 112 / Auto-skipped: 0

graphql_muc_light_SUITE:admin_cli:admin_muc_light:admin_create_room_with_unprepped_id
{error,
  {#{what => invalid_response_code,expected_type => ok,
     response_code => {exit_status,1}},
   [{graphql_helper,assert_response_code,2,
      [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
       {line,256}]},
    {graphql_helper,get_ok_value,2,
      [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
       {line,239}]},
    {graphql_muc_light_SUITE,admin_create_room_with_unprepped_id,1,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE.erl"},
       {line,1156}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1302}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log

graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:admin_create_room_with_unprepped_id
{error,
  {{badmatch,null},
   [{graphql_muc_light_SUITE,admin_create_room_with_unprepped_id,1,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE.erl"},
       {line,1155}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1302}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 2b237b1
Reports root/ big
OK: 4225 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 2b237b1
Reports root/ big
OK: 4273 / Failed: 0 / User-skipped: 110 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 2b237b1
Reports root/ big
OK: 4599 / Failed: 12 / User-skipped: 112 / Auto-skipped: 0

pep_SUITE:pep_tests:send_caps_after_login_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_caps_after_login_test_2731@localhost/res1">>,
          escalus_tcp,<0.73513.0>,
          [{event_manager,<0.73483.0>},
           {server,<<"localhost">>},
           {username,<<"alicE_send_caps_after_login_test_2731">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.73483.0>},
            {server,<<"localhost">>},
            {username,<<"alicE_send_caps_after_login_test_2731">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alice_send_caps_after_login_test_2731">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_send_caps_after_login_test_2731">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"7c222a7550efab72">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,433}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,424}]},
     {pep_S...

Report log

pep_SUITE:pep_tests:disco_sm_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alice_disco_sm_items_test_2729@localhost/res1">>,
          escalus_tcp,<0.73507.0>,
          [{event_manager,<0.73473.0>},
           {server,<<"localhost">>},
           {username,<<"alicE_disco_sm_items_test_2729">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.73473.0>},
            {server,<<"localhost">>},
            {username,<<"alicE_disco_sm_items_test_2729">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alice_disco_sm_items_test_2729">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_disco_sm_items_test_2729">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"8eddeb77b641a25a">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,433}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,424}]},
     {pep_SUITE,'-disco_sm_items_test/1-fun-2-',2,
      ...

Report log

pep_SUITE:pep_tests:authorize_access_model
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alice_authorize_access_model_2732@localhost/res1">>,
          escalus_tcp,<0.73527.0>,
          [{event_manager,<0.73490.0>},
           {server,<<"localhost">>},
           {username,<<"alicE_authorize_access_model_2732">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.73490.0>},
            {server,<<"localhost">>},
            {username,<<"alicE_authorize_access_model_2732">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alice_authorize_access_model_2732">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_authorize_access_model_2732">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"b68c040b175c73e1">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,433}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,424}]},
     {pep_SUITE,'-authorize_access_model/1...

Report log

pep_SUITE:pep_tests:publish_options_fail_wrong_value_story
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_publish_options_fail_wrong_value_story_2719@localhost/res1">>,
          escalus_tcp,<0.73501.0>,
          [{event_manager,<0.73423.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_publish_options_fail_wrong_value_story_2719">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.73423.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_publish_options_fail_wrong_value_story_2719">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_publish_options_fail_wrong_value_story_2719">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_publish_options_fail_wrong_value_story_2719">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"12232dcb4d8e544a">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pep_SUITE,'-publish_options_fail_wrong_value_story/1-fun-1-',1,
       [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
        {line,300}]},
     {escal...

Report log

pep_SUITE:pep_tests:publish_options_fail_wrong_form
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_publish_options_fail_wrong_form_2728@localhost/res1">>,
          escalus_tcp,<0.73512.0>,
          [{event_manager,<0.73468.0>},
           {server,<<"localhost">>},
           {username,<<"alicE_publish_options_fail_wrong_form_2728">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.73468.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_publish_options_fail_wrong_form_2728">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alice_publish_options_fail_wrong_form_2728">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_publish_options_fail_wrong_form_2728">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"bfed35b70249aee5">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pep_SUITE,'-publish_options_fail_wrong_form/1-fun-0-',1,
       [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
        {line,313}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/...

Report log

pep_SUITE:pep_tests:publish_options_fail_unknown_option_story
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_publish_options_fail_unknown_option_story_2722@localhost/res1">>,
          escalus_tcp,<0.73502.0>,
          [{event_manager,<0.73438.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_publish_options_fail_unknown_option_story_2722">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.73438.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_publish_options_fail_unknown_option_story_2722">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_publish_options_fail_unknown_option_story_2722">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_publish_options_fail_unknown_option_story_2722">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"392a1a7f95809bf4">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pep_SUITE,'-publish_options_fail_unknown_option_story/1-fun-0-',1,
       [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
        {line,2...

Report log

pep_SUITE:pep_tests:h_ok_after_notify_test
{error,{{assertion_failed,assert_many,false,
              [is_roster_set,is_presence,is_presence],
              [],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_story,'-make_all_clients_friends/1-fun-0-',2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,114}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1599}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1594}]},
     {escalus_utils,distinct_pairs,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,60}]},
     {escalus_story,make_all_clients_friends,1,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,106}]}]}}

Report log

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,{{assertion_failed,assert_many,false,
              [is_roster_set,is_presence,is_presence],
              [],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_story,'-make_all_clients_friends/1-fun-0-',2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,114}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1599}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1594}]},
     {escalus_utils,distinct_pairs,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,60}]},
     {escalus_story,make_all_clients_friends,1,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,106}]}]}}

Report log

pep_SUITE:pep_tests:publish_and_notify_test
{error,{{assertion_failed,assert_many,false,
              [is_roster_set,is_presence,is_presence],
              [],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_story,'-make_all_clients_friends/1-fun-0-',2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,114}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1599}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1594}]},
     {escalus_utils,distinct_pairs,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,60}]},
     {escalus_story,make_all_clients_friends,1,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,106}]}]}}

Report log

pep_SUITE:pep_tests:publish_options_success_test
{error,{{assertion_failed,assert_many,false,
              [is_roster_set,is_presence,is_presence],
              [],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_story,'-make_all_clients_friends/1-fun-0-',2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,114}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1599}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1594}]},
     {escalus_utils,distinct_pairs,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,60}]},
     {escalus_story,make_all_clients_friends,1,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,106}]}]}}

Report log

pep_SUITE:pep_tests:delayed_receive
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alice_delayed_receive_2727@localhost/res1">>,
          escalus_tcp,<0.73514.0>,
          [{event_manager,<0.73463.0>},
           {server,<<"localhost">>},
           {username,<<"alicE_delayed_receive_2727">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.73463.0>},
            {server,<<"localhost">>},
            {username,<<"alicE_delayed_receive_2727">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alice_delayed_receive_2727">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_delayed_receive_2727">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"bc4cbdb333c8d373">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pep_SUITE,make_friends,2,
       [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
        {line,633}]},
     {pep_SUITE,delayed_receive_story,3,
       [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
        {line,360}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/def...

Report log

pep_SUITE:pep_tests:delayed_receive_with_sm
{error,
  {{assertion_failed,assert_many,false,
     [is_message,is_iq,is_presence,is_presence,is_sm_ack_request,
      is_sm_ack_request,is_sm_ack_request,is_sm_ack_request],
     [{xmlel,<<"iq">>,
        [{<<"from">>,<<"bob_delayed_receive_with_sm_2733@localhost">>},
         {<<"to">>,
        <<"bob_delayed_receive_with_sm_2733@localhost/res1">>},
         {<<"id">>,<<"pusha01a6a69b0454b4a">>},
         {<<"type">>,<<"set">>}],
        [{xmlel,<<"query">>,
           [{<<"xmlns">>,<<"jabber:iq:roster">>}],
           [{xmlel,<<"item">>,
            [{<<"subscription">>,<<"to">>},
             {<<"jid">>,
              <<"alice_delayed_receive_with_sm_2733@localhost">>}],
            []}]}]},
      {xmlel,<<"r">>,[{<<"xmlns">>,<<"urn:xmpp:sm:3">>}],[]},
      {xmlel,<<"presence">>,
        [{<<"from">>,<<"alice_delayed_receive_with_sm_2733@localhost">>},
         {<<"to">>,
        <<"bob_delayed_receive_with_sm_2733@localhost/res1">>},
         {<<"type">>,<<"subscribed">>}],
        []},
      {xmlel,<<"r">>,[{<<"xmlns">>,<<"urn:xmpp:sm:3">>}],[]},
      {xmlel,<<"presence">>,
        [{<<"from">>,
        <<"alice_delayed_receive_with_sm_2733@localhost/res1">>},
         {<<"to">>,
        <<"bob_delayed_receive_with_sm_2733@localhost/res1">>}],
        []},
      {xmlel,<<"r">>,[{<<"xmlns">>,<<"urn:xmpp:sm:3">>}],[]}],
     "   <iq from='bob_delayed_receive_with_sm_2733@localhost' to='bob_delayed_receive_with_sm_2733@localhost/res1' id='pusha01a6a69b0454b4a' type='set...

Report log


mssql_mnesia_26 / odbc_mssql_mnesia / 2b237b1
Reports root/ big
OK: 4611 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

graphql_muc_light_SUITE:admin_cli:admin_muc_light:end_per_group
{error,
 {{unregistering_failed,
   {amount,2},
   {unregistered_items,
  [{{<<"_admin_invite_user_errors_1141">>,
     [{escalus_event_mgr,<0.24510.0>},
    {tc_name,admin_invite_user_errors},
    {escalus_cleaner,<0.24509.0>},
    {watchdog,<0.24508.0>},
    {muc_light_host,<<"muclight.localhost">>},
    {secondary_muc_light_host,<<"muclight.localhost.bis">>},
    {protocol,cli},
    {schema_endpoint,admin},
    {{ejabberd_cwd,mongooseim@localhost},
     "/home/circleci/project/_build/mim1/rel/mongooseim"},
    {preset,"odbc_mssql_mnesia"},
    {mim_data_dir,
     "/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
    {tc_logfile,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4185/201776/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40990612bfafef.2023-12-04_20.18.26/big_tests.tests.graphql_muc_light_SUITE.logs/run.2023-12-04_20.23.09/graphql_muc_light_suite.admin_invite_user_errors.58754.html"},
    {tc_group_properties,[{name,admin_muc_light}]},
    {tc_group_path,[[{name,admin_cli}]]},
    {data_dir,
     "/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
    {priv_dir,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4185/201776/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40990612bfafef.2023-12-04_20.18.26/big_tests.tests.graphql_muc_light_SUITE.logs/run.2023-12-04_20.23.09/log_private/"},
    {{saved_modules,mongooseim@localhost,<<"localhost">>},
     #{mod_vcard =>
      #{matches => 30,
        host => {prefix,<<"vjud.">>},
        search => true,backend => rdbms,iqdisc => parallel...

Report log

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (216342f) 84.29% compared to head (529be10) 84.10%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4185      +/-   ##
==========================================
- Coverage   84.29%   84.10%   -0.19%     
==========================================
  Files         551      551              
  Lines       33467    33467              
==========================================
- Hits        28210    28149      -61     
- Misses       5257     5318      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Includes Fix unavailableNodes list having joined nodes
esl/cets#45
@arcusfelis arcusfelis force-pushed the disco_pang_result_arrives_after_nodeup branch from 0e55672 to 529be10 Compare December 6, 2023 15:56
@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 6, 2023

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 529be10
Reports root/ big
OK: 368 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_25 / small_tests / 529be10
Reports root / small


small_tests_26 / small_tests / 529be10
Reports root / small


small_tests_26_arm64 / small_tests / 529be10
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 529be10
Reports root/ big
OK: 2268 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 529be10
Reports root/ big
OK: 2268 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 529be10
Reports root/ big
OK: 4225 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 529be10
Reports root/ big
OK: 4192 / Failed: 0 / User-skipped: 135 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 529be10
Reports root/ big
OK: 4225 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 529be10
Reports root/ big
OK: 4222 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 529be10
Reports root/ big
OK: 4273 / Failed: 0 / User-skipped: 110 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 529be10
Reports root/ big
OK: 4614 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 529be10
Reports root/ big
OK: 2408 / Failed: 0 / User-skipped: 707 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 529be10
Reports root/ big
OK: 4614 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 529be10
Reports root/ big
OK: 4593 / Failed: 0 / User-skipped: 130 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 529be10
Reports root/ big
OK: 4611 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 529be10
Reports root/ big
OK: 368 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_25 / small_tests / 529be10
Reports root / small


small_tests_26 / small_tests / 529be10
Reports root / small


small_tests_26_arm64 / small_tests / 529be10
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 529be10
Reports root/ big
OK: 2268 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 529be10
Reports root/ big
OK: 4225 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 529be10
Reports root/ big
OK: 4192 / Failed: 0 / User-skipped: 135 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 529be10
Reports root/ big
OK: 2408 / Failed: 0 / User-skipped: 707 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 529be10
Reports root/ big
OK: 2268 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 529be10
Reports root/ big
OK: 4225 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 529be10
Reports root/ big
OK: 4222 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 529be10
Reports root/ big
OK: 4614 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 529be10
Reports root/ big
OK: 4273 / Failed: 0 / User-skipped: 110 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 529be10
Reports root/ big
OK: 4592 / Failed: 1 / User-skipped: 130 / Auto-skipped: 0

sm_SUITE:ping_timeout
{error,
  {{assertion_failed,assert,is_presence,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"localhost">>},
        {<<"to">>,
         <<"alice_ping_timeout_3184@localhost/escalus-default-resource">>},
        {<<"type">>,<<"get">>},
        {<<"id">>,<<"753f81ff5a76ae5e">>}],
       [{xmlel,<<"ping">>,[{<<"xmlns">>,<<"urn:xmpp:ping">>}],[]}]},
     "<iq from='localhost' to='alice_ping_timeout_3184@localhost/escalus-default-resource' type='get' id='753f81ff5a76ae5e'><ping xmlns='urn:xmpp:ping'/></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {sm_helper,initial_presence_step,2,
      [{file,"/home/circleci/project/big_tests/tests/sm_helper.erl"},
       {line,135}]},
    {escalus_connection,connection_step,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
       {line,163}]},
    {lists,foldl_1,3,[{file,"lists.erl"},{line,1599}]},
    {escalus_connection,start,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
       {line,145}]},
    {sm_helper,connect_spec,3,
      [{file,"/home/circleci/project/big_tests/tests/sm_helper.erl"},
       {line,153}]},
    {sm_SUITE,ping_timeout,1,
      [{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
       {line,625}]},
    {test_server,ts_tc,3,[{file,"test_ser...

Report log


pgsql_mnesia_26 / pgsql_mnesia / 529be10
Reports root/ big
OK: 4614 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 529be10
Reports root/ big
OK: 4611 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 529be10
Reports root/ big
OK: 4593 / Failed: 0 / User-skipped: 130 / Auto-skipped: 0


elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 529be10
Reports root/ big
OK: 368 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_26 / small_tests / 529be10
Reports root / small


small_tests_25 / small_tests / 529be10
Reports root / small


small_tests_26_arm64 / small_tests / 529be10
Reports root / small


dynamic_domains_mysql_redis_26 / mysql_redis / 529be10
Reports root/ big
OK: 4191 / Failed: 1 / User-skipped: 135 / Auto-skipped: 0

carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_dropped_client_doesnt_create_duplicate_carbons_580@domain.example.com">>},
         {<<"to">>,
        <<"alice_dropped_client_doesnt_create_duplicate_carbons_580@domain.example.com/res2">>},
         {<<"xmlns">>,<<"jabber:client">>},
         {<<"type">>,<<"chat">>}],
        [{xmlel,<<"sent">>,
           [{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
           [{xmlel,<<"forwarded">>,
            [{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
            [{xmlel,<<"message">>,
               [{<<"from">>,
                 <<"alice_dropped_client_doesnt_create_duplicate_carbons_580@domain.example.com/res1">>},
                {<<"type">>,<<"chat">>},
                {<<"to">>,
                 <<"bob_dropped_client_doesnt_create_duplicate_carbons_580@domain.example.com/res1">>},
                {<<"xmlns">>,<<"jabber:client">>}],
               [{xmlel,<<"body">>,[],
                  [{xmlcdata,
                     <<"And pious action">>}]}]}]}]}]}]},
   [{carboncopy_SUITE,
      '-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
      [{file,
         "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
       {line,189}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_c...

Report log


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 529be10
Reports root/ big
OK: 4225 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 529be10
Reports root/ big
OK: 2268 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 529be10
Reports root/ big
OK: 2268 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 529be10
Reports root/ big
OK: 4225 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 529be10
Reports root/ big
OK: 4222 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:end_per_group
{error,
 {{unregistering_failed,
   {amount,1},
   {unregistered_items,
  [{{<<"_admin_invite_user_1109">>,
     [{escalus_event_mgr,<0.24813.0>},
    {tc_name,admin_invite_user},
    {escalus_cleaner,<0.24812.0>},
    {watchdog,<0.24811.0>},
    {muc_light_host,<<"muclight.domain.example.com">>},
    {secondary_muc_light_host,<<"muclight.domain.example.org">>},
    {protocol,http},
    {domain_admin,{<<"[email protected]">>,<<"c3e46df34af5d53c">>}},
    {schema_endpoint,domain_admin},
    {{ejabberd_cwd,mongooseim@localhost},
     "/home/circleci/project/_build/mim1/rel/mongooseim"},
    {preset,"odbc_mssql_mnesia"},
    {mim_data_dir,
     "/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
    {tc_logfile,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4185/202139/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%4084bb93c80e5f.2023-12-07_07.46.42/big_tests.tests.graphql_muc_light_SUITE.logs/run.2023-12-07_07.51.00/graphql_muc_light_suite.admin_invite_user.12933.html"},
    {tc_group_properties,[{name,domain_admin_muc_light}]},
    {tc_group_path,[[{name,domain_admin}]]},
    {data_dir,
     "/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
    {priv_dir,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4185/202139/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%4084bb93c80e5f.2023-12-07_07.46.42/big_tests.tests.graphql_muc_light_SUITE.logs/run.2023-12-07_07.51.00/log_private/"},
    {{saved_modules,mongooseim@localhost,<<"test type">>},
     #{mod_vcard =>
      #{matches => 30,
        h...

Report log


pgsql_cets_26 / pgsql_cets / 529be10
Reports root/ big
OK: 4273 / Failed: 0 / User-skipped: 110 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 529be10
Reports root/ big
OK: 2407 / Failed: 1 / User-skipped: 707 / Auto-skipped: 0

pubsub_SUITE:tree+basic:discover_nodes_test
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,444}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,434}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,424}]},
     {pubsub_SUITE,'-discover_nodes_test/1-fun-0-',2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
            {line,290}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1302}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1234}]}]}}

Report log


mysql_redis_26 / mysql_redis / 529be10
Reports root/ big
OK: 4593 / Failed: 0 / User-skipped: 130 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 529be10
Reports root/ big
OK: 4614 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 529be10
Reports root/ big
OK: 4614 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 529be10
Reports root/ big
OK: 4611 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

graphql_muc_light_SUITE:user:user_muc_light:end_per_group
{error,
 {{unregistering_failed,
   {amount,1},
   {unregistered_items,
  [{{<<"_user_delete_room_1011">>,
     [{escalus_event_mgr,<0.23333.0>},
    {tc_name,user_delete_room},
    {escalus_cleaner,<0.23332.0>},
    {watchdog,<0.23331.0>},
    {muc_light_host,<<"muclight.localhost">>},
    {secondary_muc_light_host,<<"muclight.localhost.bis">>},
    {schema_endpoint,user},
    {{ejabberd_cwd,mongooseim@localhost},
     "/home/circleci/project/_build/mim1/rel/mongooseim"},
    {preset,"odbc_mssql_mnesia"},
    {mim_data_dir,
     "/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
    {tc_logfile,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4185/202145/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40e2a4bb4f61b7.2023-12-07_07.46.55/big_tests.tests.graphql_muc_light_SUITE.logs/run.2023-12-07_07.51.12/graphql_muc_light_suite.user_delete_room.59138.html"},
    {tc_group_properties,[{name,user_muc_light},parallel]},
    {tc_group_path,[[{name,user}]]},
    {data_dir,
     "/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
    {priv_dir,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4185/202145/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40e2a4bb4f61b7.2023-12-07_07.46.55/big_tests.tests.graphql_muc_light_SUITE.logs/run.2023-12-07_07.51.12/log_private/"},
    {{saved_modules,mongooseim@localhost,<<"localhost">>},
     #{mod_vcard =>
      #{matches => 30,
        host => {prefix,<<"vjud.">>},
        search => true,backend => rdbms,iqdisc => parallel},
       mod_roster =>
      #{backend =>...

Report log

@arcusfelis arcusfelis marked this pull request as ready for review December 6, 2023 23:37
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chrzaszcz chrzaszcz merged commit ad3820e into master Dec 7, 2023
3 of 4 checks passed
@chrzaszcz chrzaszcz deleted the disco_pang_result_arrives_after_nodeup branch December 7, 2023 09:02
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants