Migrate from inside shapers to opuntia #4187
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4187 +/- ##
==========================================
+ Coverage 84.24% 84.30% +0.05%
==========================================
Files 551 549 -2
Lines 33473 33419 -54
==========================================
- Hits 28201 28175 -26
+ Misses 5272 5244 -28 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
I added a few comments. Apart from what I added in NelsonVides/opuntia#1 (review), I think that we could keep mongoose_shaper as the interface to shapers, because now we sometimes use this module, and for some functions we call opuntia directly.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 565e636 small_tests_25 / small_tests / 565e636 small_tests_26 / small_tests / 565e636 small_tests_26_arm64 / small_tests / 565e636 ldap_mnesia_25 / ldap_mnesia / 565e636 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 565e636 dynamic_domains_mysql_redis_26 / mysql_redis / 565e636 ldap_mnesia_26 / ldap_mnesia / 565e636 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 565e636 pgsql_mnesia_25 / pgsql_mnesia / 565e636 pgsql_cets_26 / pgsql_cets / 565e636 internal_mnesia_26 / internal_mnesia / 565e636 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 565e636 mysql_redis_26 / mysql_redis / 565e636 pgsql_mnesia_26 / pgsql_mnesia / 565e636 mssql_mnesia_26 / odbc_mssql_mnesia / 565e636 |
There's the repo called https://github.com/NelsonVides/opuntia where I pretty much moved shaper code and improved and tested that it really shapes the traffic with certainty (current code because of rounding errors could pass up to 49.99% more than allowed).
Also that codebase is tested using PropER's stateful testing using state machines modelling, which is what I really wanted to get at, there.
This PR simply uses that and functionality from
wpoolto remove internal shaper code andmongoose_shaper_sup.