Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pools/per host type #4229

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Pools/per host type #4229

merged 2 commits into from
Feb 29, 2024

Conversation

NelsonVides
Copy link
Collaborator

@NelsonVides NelsonVides commented Feb 26, 2024

This PR addresses MIM-1431 and solves the previously failed MIM-1430.

It changes the pool scope configuration to use scope = "host_type" or scope = "single_host_type", therefore finally upgrading this part of the config to host_types.

@mongoose-im

This comment was marked as outdated.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (786f3a2) to head (2f57ec6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4229      +/-   ##
==========================================
+ Coverage   84.37%   84.38%   +0.01%     
==========================================
  Files         552      552              
  Lines       33528    33531       +3     
==========================================
+ Hits        28290    28296       +6     
+ Misses       5238     5235       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NelsonVides NelsonVides changed the base branch from master to pools/rdbms_pool_tags February 26, 2024 15:23
@NelsonVides NelsonVides force-pushed the pools/per_host_type branch 2 times, most recently from 93de599 to d9d9773 Compare February 26, 2024 15:27
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@NelsonVides NelsonVides force-pushed the pools/rdbms_pool_tags branch 2 times, most recently from 6597730 to 03a4175 Compare February 28, 2024 10:16
@mongoose-im

This comment was marked as outdated.

Base automatically changed from pools/rdbms_pool_tags to master February 28, 2024 15:17
@NelsonVides NelsonVides force-pushed the pools/per_host_type branch 2 times, most recently from 587613e to d44f39f Compare February 28, 2024 15:21
@mongoose-im

This comment was marked as outdated.

@NelsonVides NelsonVides marked this pull request as ready for review February 28, 2024 16:32
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌 - I only proposed some minor naming improvements.

doc/configuration/outgoing-connections.md Outdated Show resolved Hide resolved
doc/configuration/outgoing-connections.md Outdated Show resolved Hide resolved
src/config/mongoose_config_spec.erl Outdated Show resolved Hide resolved
test/config_parser_SUITE.erl Outdated Show resolved Hide resolved
src/config/mongoose_config_spec.erl Outdated Show resolved Hide resolved
@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 29, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 2f57ec6
Reports root/ big
OK: 429 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0


small_tests_25 / small_tests / 2f57ec6
Reports root / small


small_tests_26 / small_tests / 2f57ec6
Reports root / small


small_tests_26_arm64 / small_tests / 2f57ec6
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 2f57ec6
Reports root/ big
OK: 2275 / Failed: 0 / User-skipped: 895 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 2f57ec6
Reports root/ big
OK: 4502 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 2f57ec6
Reports root/ big
OK: 2275 / Failed: 0 / User-skipped: 895 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 2f57ec6
Reports root/ big
OK: 4469 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 2f57ec6
Reports root/ big
OK: 4502 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 2f57ec6
Reports root/ big
OK: 2415 / Failed: 0 / User-skipped: 755 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 2f57ec6
Reports root/ big
OK: 4891 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 2f57ec6
Reports root/ big
OK: 4425 / Failed: 0 / User-skipped: 178 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 2f57ec6
Reports root/ big
OK: 4499 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 2f57ec6
Reports root/ big
OK: 4891 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 2f57ec6
Reports root/ big
OK: 4870 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 2f57ec6
Reports root/ big
OK: 4886 / Failed: 2 / User-skipped: 121 / Auto-skipped: 0

graphql_muc_light_SUITE:admin_http:admin_muc_light:end_per_group
{error,
 {{unregistering_failed,
   {amount,1},
   {unregistered_items,
  [{{<<"_admin_send_message_to_room_1046">>,
     [{escalus_event_mgr,<0.23949.0>},
    {tc_name,admin_send_message_to_room},
    {escalus_cleaner,<0.23948.0>},
    {watchdog,<0.23947.0>},
    {muc_light_host,<<"muclight.localhost">>},
    {secondary_muc_light_host,<<"muclight.localhost.bis">>},
    {protocol,http},
    {schema_endpoint,admin},
    {listener_opts,
     #{module => mongoose_graphql_handler,path => "/api/graphql",
       host => "localhost",username => <<"admin">>,
       password => <<"secret">>,schema_endpoint => admin,
       sse_idle_timeout => 3600000}},
    {{ejabberd_cwd,mongooseim@localhost},
     "/home/circleci/project/_build/mim1/rel/mongooseim"},
    {preset,"odbc_mssql_mnesia"},
    {mim_data_dir,
     "/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
    {tc_logfile,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4229/210056/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40b4ca631ec94e.2024-02-29_08.03.05/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-02-29_08.07.29/graphql_muc_light_suite.admin_send_message_to_room.html"},
    {tc_group_properties,[{name,admin_muc_light}]},
    {tc_group_path,[[{name,admin_http}]]},
    {data_dir,
     "/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
    {priv_dir,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4229/210056/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40b4ca631ec94e.2024-02-29_08.03.05/big_tests.tests.graphql_muc_light_SUITE.logs/ru...

Report log

graphql_muc_light_SUITE:admin_cli:admin_muc_light:admin_create_room_with_unprepped_id
{error,
  {#{what => invalid_response_code,expected_type => ok,
     response_code => {exit_status,1}},
   [{graphql_helper,assert_response_code,2,
      [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
       {line,256}]},
    {graphql_helper,get_ok_value,2,
      [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
       {line,239}]},
    {graphql_muc_light_SUITE,admin_create_room_with_unprepped_id,1,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE.erl"},
       {line,1156}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1302}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log

graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:admin_create_room_with_unprepped_id
{error,
  {{badmatch,null},
   [{graphql_muc_light_SUITE,admin_create_room_with_unprepped_id,1,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE.erl"},
       {line,1155}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1302}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log


mssql_mnesia_26 / odbc_mssql_mnesia / 2f57ec6
Reports root/ big
OK: 4888 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chrzaszcz chrzaszcz merged commit fd0720d into master Feb 29, 2024
4 checks passed
@chrzaszcz chrzaszcz deleted the pools/per_host_type branch February 29, 2024 09:06
@jacekwegr jacekwegr added this to the 6.2.1 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants