-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pools/per host type #4229
Pools/per host type #4229
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4229 +/- ##
==========================================
+ Coverage 84.37% 84.38% +0.01%
==========================================
Files 552 552
Lines 33528 33531 +3
==========================================
+ Hits 28290 28296 +6
+ Misses 5238 5235 -3 ☔ View full report in Codecov by Sentry. |
b4ccd64
to
03d32bd
Compare
93de599
to
d9d9773
Compare
This comment was marked as outdated.
This comment was marked as outdated.
e1f6ee8
to
3d20474
Compare
d9d9773
to
c6d48dd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
c6d48dd
to
20bd4a2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
20bd4a2
to
317772c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
317772c
to
dbc7eac
Compare
This comment was marked as outdated.
This comment was marked as outdated.
94b84c3
to
254f9b0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
907a32a
to
070ad29
Compare
254f9b0
to
b54c2cc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
070ad29
to
7cdbf55
Compare
b54c2cc
to
480f84c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
480f84c
to
f891adf
Compare
This comment was marked as outdated.
This comment was marked as outdated.
6597730
to
03a4175
Compare
f891adf
to
2eb1e23
Compare
This comment was marked as outdated.
This comment was marked as outdated.
587613e
to
d44f39f
Compare
d44f39f
to
473b8be
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👌 - I only proposed some minor naming improvements.
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 2f57ec6 small_tests_25 / small_tests / 2f57ec6 small_tests_26 / small_tests / 2f57ec6 small_tests_26_arm64 / small_tests / 2f57ec6 ldap_mnesia_25 / ldap_mnesia / 2f57ec6 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 2f57ec6 ldap_mnesia_26 / ldap_mnesia / 2f57ec6 dynamic_domains_mysql_redis_26 / mysql_redis / 2f57ec6 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 2f57ec6 internal_mnesia_26 / internal_mnesia / 2f57ec6 pgsql_mnesia_25 / pgsql_mnesia / 2f57ec6 pgsql_cets_26 / pgsql_cets / 2f57ec6 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 2f57ec6 pgsql_mnesia_26 / pgsql_mnesia / 2f57ec6 mysql_redis_26 / mysql_redis / 2f57ec6 mssql_mnesia_26 / odbc_mssql_mnesia / 2f57ec6 graphql_muc_light_SUITE:admin_http:admin_muc_light:end_per_group{error,
{{unregistering_failed,
{amount,1},
{unregistered_items,
[{{<<"_admin_send_message_to_room_1046">>,
[{escalus_event_mgr,<0.23949.0>},
{tc_name,admin_send_message_to_room},
{escalus_cleaner,<0.23948.0>},
{watchdog,<0.23947.0>},
{muc_light_host,<<"muclight.localhost">>},
{secondary_muc_light_host,<<"muclight.localhost.bis">>},
{protocol,http},
{schema_endpoint,admin},
{listener_opts,
#{module => mongoose_graphql_handler,path => "/api/graphql",
host => "localhost",username => <<"admin">>,
password => <<"secret">>,schema_endpoint => admin,
sse_idle_timeout => 3600000}},
{{ejabberd_cwd,mongooseim@localhost},
"/home/circleci/project/_build/mim1/rel/mongooseim"},
{preset,"odbc_mssql_mnesia"},
{mim_data_dir,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
{tc_logfile,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4229/210056/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40b4ca631ec94e.2024-02-29_08.03.05/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-02-29_08.07.29/graphql_muc_light_suite.admin_send_message_to_room.html"},
{tc_group_properties,[{name,admin_muc_light}]},
{tc_group_path,[[{name,admin_http}]]},
{data_dir,
"/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
{priv_dir,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4229/210056/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40b4ca631ec94e.2024-02-29_08.03.05/big_tests.tests.graphql_muc_light_SUITE.logs/ru... graphql_muc_light_SUITE:admin_cli:admin_muc_light:admin_create_room_with_unprepped_id{error,
{#{what => invalid_response_code,expected_type => ok,
response_code => {exit_status,1}},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,256}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,239}]},
{graphql_muc_light_SUITE,admin_create_room_with_unprepped_id,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE.erl"},
{line,1156}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:admin_create_room_with_unprepped_id{error,
{{badmatch,null},
[{graphql_muc_light_SUITE,admin_create_room_with_unprepped_id,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE.erl"},
{line,1155}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} mssql_mnesia_26 / odbc_mssql_mnesia / 2f57ec6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR addresses MIM-1431 and solves the previously failed MIM-1430.
It changes the pool scope configuration to use
scope = "host_type"
orscope = "single_host_type"
, therefore finally upgrading this part of the config to host_types.