Handle ws 'close' element properly #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only the legacy 'stream' closing tag was handled, leading to a crash, restart and inability to detect that the server closed the connection.
chrzaszcz
force-pushed
the
fix-ws-close
branch
from
6128b7e
to
b3d9b0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only the legacy 'stream' closing tag was handled, leading to a crash, restart and inability to detect that the server closed the connection.
Note: The branch stems from
4.2.10, notmaster, because the latter does not work in big tests because of #259. There is a fix needed, but it is independent from this PR.Recommended for the future: add OTP 26 to CI.