Adding support for stream_management to escalus_ws #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanuszJakubiec
force-pushed
the
ws-stream-management
branch
3 times, most recently
from
ada85a0
to
821f1ac
Compare
JanuszJakubiec
force-pushed
the
ws-stream-management
branch
from
821f1ac
to
ca24321
Compare
JanuszJakubiec
force-pushed
the
ws-stream-management
branch
from
e415d2e
to
d345b52
Compare
JanuszJakubiec
changed the title
chrzaszcz
reviewed
Jun 17, 2024
JanuszJakubiec
changed the base branch from
master
to
feature/ws_stream_management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for stream management in escalus_ws.
I've also changed escalus_ws opts format from proplist to map. I've added a function containing the options' default values.MongooseIM PR testing this escalus version: https://github.com/esl/MongooseIM/pull/4303/checks?check_run_id=26227811268