Extract stream features #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`escalus_connection:transport()` doesn't exist anymore.
Since 1658f58 this type is used but not defined - Dialyzer weeps.
Fix `escalus_connection:start/2` callsites in `escalus_users`. There's a corresponding fix for ejabberd_tests - see tests branch fix-connection-start2.
erszcz
force-pushed
the
extract-stream-features
branch
from
d63bf19
to
7f2edfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
start_streamconnection step into two:<stream:stream>elements,<stream:features>.This allows to plug into the connection process just after establishing the stream, e.g. for inspecting the raw features returned by the server inside a testcase.
This builds on top of #36, so please look into it first.