Ranch 2.1 compatibility #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'socket' option is not supported anymore, and this means that: - either new protocol modules would need to be implemented for TCP and TLS - or ranch_tcp and ranch_tls could be used respectively. This commit uses the second option for simplicity. It required moving some initialization logic to 'ranch_init', because the socket is not available before.
Use the latest cowboy and ranch, just like MongooseIM. The cowboy-specific functionality might not work correctly, but it is unused by MongooseIM.
NelsonVides
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ranch 2.1, which is required by mongoose c2s.
The target branch is now called
mongooseim-ranch-compatibility, and is an exact copy of https://github.com/michalwski/nkpacket/tree/ranch-1.7-compatibility, which was used by MongooseIM. That branch contained a quick fix, which enabled using thenksiplistener with MongooseIM. However, the support for ranch 1.7 was only partial, and functionality not required by MongooseIM was not working.I decided to continue on that route to avoid any significant rewrite of the library, because MongooseIM is only using a small part of it. As a result, the change only enables listening for and accepting TCP connections with ranch 2.1. The
jingle_SUITEpasses in MongooseIM. Unfortunately we don't have any further tests, but I think that the functionality is a lower-priority one, and this should be enough for now.