ci: swap release process to release-please #508
Merged
+72
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think we also need to replace the version in package.json with eslint-plugin-promise/package.json Line 3 in 602d825 |
|
@ota-meshi Good point, fixed! |
voxpelli
force-pushed
the
voxpelli/issue506
branch
from
cb7f116
to
6d145b8
Compare
|
The linting error should be fixed in #507. |
ota-meshi
approved these changes
Jul 24, 2024
Its copied from |
Likewise... |
voxpelli
added a commit
that referenced
this pull request
Jul 24, 2024
**What is the purpose of this pull request?** To assist #508 / #506 by ensuring that PR-title's are always valid conventional commit format before merging **What changes did you make? (Give an overview)** Added a pinned [mtfoley/pr-compliance-action](https://github.com/mtfoley/pr-compliance-action) similar to what I use at eg. neostandard: https://github.com/neostandard/neostandard/blob/main/.github/workflows/compliance.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
To improve the release process by swapping to release-please. Fixes #506
What changes did you make? (Give an overview)
Removed
cycjimmy/semantic-release-actionand addedgoogleapis/release-please-action