Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Support conventional commits #55

Merged
merged 3 commits into from
May 4, 2021
Merged

Update: Support conventional commits #55

merged 3 commits into from
May 4, 2021

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Apr 26, 2021

This change allows eslint-release to interpret conventional commit-style commit messages to generate the correct release information. This will allow us to transition from our own commit message style into conventional commits without disrupting our releases.

Note: Conventional commits uses "feat" to be equivalent to both "New" and "Update" for us. For simplicity, I decided to map "feat" to "New".

.eslintrc.yml Outdated Show resolved Hide resolved
@nzakas
Copy link
Member Author

nzakas commented Apr 29, 2021

Fixed linting errors.

lib/release-ops.js Show resolved Hide resolved
tests/lib/release-ops.js Show resolved Hide resolved
lib/release-ops.js Show resolved Hide resolved
btmills
btmills previously approved these changes Apr 30, 2021
aladdin-add
aladdin-add previously approved these changes Apr 30, 2021
@aladdin-add
Copy link
Member

a conflict needs to be fixed.

@nzakas
Copy link
Member Author

nzakas commented Apr 30, 2021

Conflicts resolved.

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@nzakas nzakas merged commit 0fdda4d into main May 4, 2021
@nzakas nzakas deleted the conventional branch May 4, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants