Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

fix: ignore "use strict" directives in ES3 #87

Merged
merged 1 commit into from
Feb 5, 2022
Merged

fix: ignore "use strict" directives in ES3 #87

merged 1 commit into from
Feb 5, 2022

Conversation

mdjermanovic
Copy link
Member

Fixes #86 by setting Scope#isStrict to false on all scopes if ecmaVersion < 5.

@mdjermanovic mdjermanovic mentioned this pull request Feb 4, 2022
Closed
nzakas
nzakas approved these changes Feb 5, 2022
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit 4e1d24c into main Feb 5, 2022
@nzakas nzakas deleted the es3-usestrict branch February 5, 2022 01:27
@mdjermanovic mdjermanovic mentioned this pull request Feb 9, 2022
Merged
1 task
ljharb added a commit to ljharb/eslint-config that referenced this pull request Feb 12, 2022
@ljharb
[Fix] pin eslint to < v8.9, since it breaks ES3 strict mode parsing
a6efbad 
See eslint/eslint#15595 / eslint/eslint-scope#87 / eslint/eslint-scope#86 / eslint/eslint#15456
ljharb added a commit to ljharb/eslint-config that referenced this pull request Feb 13, 2022
@ljharb
[Fix] pin eslint-scope, since v7.1.1+ breaks ES3 strict mode parsing
3f418db 
See eslint/eslint#15595 / eslint/eslint-scope#87 / eslint/eslint-scope#86 / eslint/eslint#15456
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nzakas nzakas nzakas approved these changes

Assignees
No one assigned
Labels
bug evaluating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"use strict" in ES3
2 participants
@mdjermanovic @nzakas