-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brace-style 1tbs with allowSingleLine should not allow else on separate line #12284
Comments
Thanks for this issue. However, |
It seems to me that the example I gave is a weird mix of single line and 1tbs since it’s not valid 1tbs, but it’s also not a single line statement. |
PRs to improve documentation are always welcome! |
Cool. I’d be happy to contribute. |
@kardasis If you're proposing a rule change, do you mind filling out the rule change template with the updated proposal? Either updating the original comment or adding a new comment would be fine! Once we have a formal proposal, the team can evaluate it. |
I'll be submitting a PR with the docs shortly. |
add documentation and tests demonstrating iffy edge cases
add documentation and tests demonstrating iffy edge cases
Add documentation and tests demonstrating iffy edge cases
Add documentation and tests demonstrating iffy edge cases
Unfortunately, it looks like there wasn't enough interest from the team Thanks for contributing to ESLint and we appreciate your understanding. |
What rule do you want to change?
brace-style
Does this change cause the rule to produce more or fewer warnings?
more
How will the change be implemented? (New option, new default behavior, etc.)?
new default behavior
Please provide some example code that this change will affect:
What does the rule currently do for this code?
It does not produce an error
What will the rule do after it's changed?
Produce an error indicating that you are mixing allowSingleLine with multiple lines
Are you willing to submit a pull request to implement this change?
yes
The text was updated successfully, but these errors were encountered: