Update: --quiet should not supress --max-warnings (fixes #14202)
#14242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
added
bug
aladdin-add
approved these changes
Mar 23, 2021
|
@aladdin-add I got a notification from you that this didn't work when tested locally. Is that still the case? |
|
I forgot to checkout to the branch ＞﹏＜, it was working fine after checking out to the right branch. sorry for the misleading! :) |
btmills
approved these changes
Mar 24, 2021
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
fixes #14202
What changes did you make? (Give an overview)
ESLint will now return exit code 1 and show the "too many warnings" error message when the number of warnings exceeds
--max-warningseven if the--quietflag was used. ESLint will still not show the actual warnings in that case.Is there anything you'd like reviewers to focus on?
Marked as "Update" since it can produce exit code 1 for runs that used to have exit code 0.