Breaking: require Node.js 6+, upgrade [email protected] (fixes #345) #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commits: [46261f6] fix regexp on node 9
package.json
Outdated
| @@ -10,7 +10,7 @@ | |||
| "espree.js" | |||
| ], | |||
| "engines": { | |||
| "node": ">=0.10.0" | |||
| "node": ">=4.0.0" | |||
There was a problem hiding this comment.
Since we're doing a breaking change, should we change this to >=6.0.0 to be the same as ESLint v5?
aladdin-add
commented
Mar 15, 2018
| @@ -47,7 +47,7 @@ module.exports = { | |||
| 0, | |||
| 8 | |||
| ], | |||
| "value": null, | |||
| "value": process.versions.node >= "9.0.0" ? new RegExp(String.raw`(?<!a)`) : null, | |||
There was a problem hiding this comment.
emm, this failed. seems Node.js 8 doesn't support these features, checking Node.js version seems not a good idea, thougths?
There was a problem hiding this comment.
For unicode regexes, the tests use the conditionalRegex helper. Would that work here?
It's not related to the issue, but I think using >= "9.0.0" will fail when Node 10.0.0 comes out, because it compares the version alphabetically.
| @@ -1,3 +1,5 @@ | |||
| const condtionalRegex = require("../../../../lib/conditional-regex-value"); | |||
There was a problem hiding this comment.
Nitpick: I think the variable name is misspelled here (it is missing an "i" after "cond").
aladdin-add
changed the title
aladdin-add
changed the title
not-an-aardvark
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.