issues/138--metadatadate-validation-error --> 1.0.0 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… getElementSelectorInputValue() Here we create a special purpose override of \Drupal\webform\Plugin\WebformElementBase::getElementSelectorInputValue at \Drupal\webform_strawberryfield\Plugin\WebformElement\MetadataDateBase::getElementSelectorInputValue It attempts to apply the selector to the MetadataDateBase form element and get the value. We handle both single and multiple value versions of the field. If the selector results in an array, we return it unless it is empty. This will trigger a array to string conversion notice downstream in \Drupal\webform\WebformSubmissionConditionsValidator::checkConditionTrigger, but that's ok/appropriate.
|
@patdunlavey when you say "his will trigger a array to string conversion notice downstream in \Drupal\webform\WebformSubmissionConditionsValidator::checkConditionTrigger, but that's ok/appropriate." Can we fix that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #138
Here we create a special purpose override of \Drupal\webform\Plugin\WebformElementBase::getElementSelectorInputValue at \Drupal\webform_strawberryfield\Plugin\WebformElement\MetadataDateBase::getElementSelectorInputValue
It attempts to apply the selector to the MetadataDateBase form element and get the value. We handle both single and multiple value versions of the field. If the selector results in an array,
we return it unless it is empty. This will trigger a array to string conversion notice downstream in \Drupal\webform\WebformSubmissionConditionsValidator::checkConditionTrigger, but that's ok/appropriate.