nvme-tcp: block BH in sk state_change sk callback

The TCP stack can run from process context for a long time so we should disable BH here. Fixes: 3f2304f ("nvme-tcp: add NVMe over TCP host driver") Signed-off-by: Sagi Grimberg <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
esmil · Apr 2, 2021 · 8b73b45 · 8b73b45
1 parent 79695dc
commit 8b73b45
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
@@ -870,7 +870,7 @@ static void nvme_tcp_state_change(struct sock *sk)
 {
 	struct nvme_tcp_queue *queue;
 
-	read_lock(&sk->sk_callback_lock);
+	read_lock_bh(&sk->sk_callback_lock);
 	queue = sk->sk_user_data;
 	if (!queue)
 		goto done;
@@ -891,7 +891,7 @@ static void nvme_tcp_state_change(struct sock *sk)
 
 	queue->state_change(sk);
 done:
-	read_unlock(&sk->sk_callback_lock);
+	read_unlock_bh(&sk->sk_callback_lock);
 }
 
 static inline bool nvme_tcp_queue_more(struct nvme_tcp_queue *queue)