Fix issue #1482 - not allow using option with missing argument #1485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
master
or3.1-STABLE
) to which this pull request applies:master
Issues fixed (if any):
Issue of argument '-i' when omitting the value #1482
Brief description of code changes (suitable for use as a commit message):
Suggested fix for preventing iperf3 from using an option as a missing argument for the previous option. I.e. in
-i -u
the "-u" was used as the-i
argument, and the default TCP was running instead of UDP test.The suggested fix assumes that negative argument is not allowed for all numeric options, and that no string argument can start with "-" (e.g. for
title
,extra-data
,username
,file
). A more robust fix could be by checking thatoptarg
is numeric in each case whereatoi()
is used.