Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ESP-IDF prerequisites and probe-rs improvements #132

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Update ESP-IDF prerequisites and probe-rs improvements #132

merged 2 commits into from
Dec 14, 2023

Conversation

SergioGasquez
Copy link
Member

  • Clarify which ESP-IDF requirements are needed for every OS
  • Update some minor probe-rs stuff:
    • We no longer need the --format idf arg
    • "channelNumber": "0", may throw an error because it's not expecting a String.

MabezDev
MabezDev approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SergioGasquez SergioGasquez merged commit bbbe5ed into esp-rs:main Dec 14, 2023
1 check passed
@SergioGasquez SergioGasquez deleted the feat/update-requirements branch December 14, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioGasquez @MabezDev