perf: vectored interrupt improvements #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of building a table of _all_ configured interrupts, we now only check the currently _pending_ interrupts configuration status. This means in the best case scenario we only ever do _one_ lookup instead of the 60~ we did before. Tested on esp32c3, gpio_interrupt: Before: 850cycles from `handler_interrupts` to the actual handler After: 125cycles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of building a table of all configured interrupts,
we now only check the currently pending interrupts configuration
status. This means in the best-case scenario we only ever do one
lookup instead of the 60+ we did before.
Tested on esp32c3, gpio_interrupt example:
Before: 850cycles from
handler_interruptsto the actual handlerAfter: 125cycles
Closes #119