Add a lint-packages subcommand to xtask, use in CI workflow
#1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now lints most of our packages using
clippy. I have excludedexamplesandhil-testfor the time being.Happy to make any changes, I've made some assumptions here but don't feel too strongly about any of them. Still not super happy with this, but better than before at least IMO. I'm sure we'll iterate on this.
The
clippywarnings inesp-backtracewere a bit strange, don't fully understand them honestly, so I've mostly just silenced the offending rules for now.