Add more configuration symbols and simplify the build script #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
reviewed
Nov 17, 2022
| Adc = 8, | ||
| #[cfg(esp32s3)] |
There was a problem hiding this comment.
not sure this way of defining DmaPeripheral will work fine in future - e.g. on C6 9 is PARLIO while on S3 it's RMT - not much of a problem now but no idea how these IDs will look like for future chips
There was a problem hiding this comment.
Okay, well at least the existing chips can share a definition I think. If we need to re-introduce a #[cfg] and one or more DmaPeripherals enums in the future we can do so.
bjoernQ
reviewed
Nov 17, 2022
jessebraham
force-pushed
the
feature/cfg
branch
from
b79beca
to
e1f1907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a number of new symbols here to hopefully make our code a bit easier to reason about. I've also changed our approach in the build script, where each chip just defines all of its symbols now. I think this will be easier to maintain.
I was careful when changing the
#[cfg]s but it's always possible I've made a mistake, so @MabezDev @bjoernQ please double check my work if you could! I've also consolidated theDmaPeripheralenums, and again while I've already checked this please review it.Not sure how many more symbols we can pull out right now, but if I've missed anything let me know!