Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize I2S RX Implementation #274

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Finalize I2S RX Implementation #274

merged 1 commit into from
Nov 24, 2022

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Nov 24, 2022

  • handles incompletely filled DMA RX descriptor buffers
  • uses fractional dividers to better match the given sample rate
  • basic API documentation

jessebraham
jessebraham approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working as far as I can tell (only tested with LA) so LGTM, thanks! 😁

@jessebraham jessebraham merged commit fbd912a into esp-rs:main Nov 24, 2022
@bjoernQ bjoernQ deleted the fix-i2s-rx branch December 14, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernQ @jessebraham