Implementing async feature for USB Serial/JTAG peripheral.
#632
Conversation
|
Solving #633 will allow to get this merged |
There was a problem hiding this comment.
This looks quite good to me, thanks for your work here! I've left a couple small comments, but honestly nothing worth blocking merging on. If you get a chance to update them that'd be great, if not no worries. This PR will need to be rebased, though.
I think if we're blocking this PR only on the ESP32-S3 issues, that there is no real need to do so and we can merge it and then we already have an issue to remind ourselves.
|
#633 has been resolved, so after a rebase this PR should (hopefully) be in good shape! |
Fix: Interrupt name
PS. : Yet only for esp32c3, we need to update PACs Temporary example fix
+ Update examples according to upstream + Code cleaning Rust format
playfulFence
force-pushed
the
async/usb_serial
branch
from
352c5c4
to
048ad13
Compare
playfulFence
force-pushed
the
async/usb_serial
branch
from
942109c
to
99c48bb
Compare
Typo fix Fix fmt
playfulFence
force-pushed
the
async/usb_serial
branch
from
99c48bb
to
683a44f
Compare
|
FYI I've patched the USB serial jtag interrupts to all be |
|
…s#632) * Implementing ASYNC features for USB_SERIAL_JTAG (work in progress) Fix: Interrupt name * Async works for USB Serial/JTAG PS. : Yet only for esp32c3, we need to update PACs Temporary example fix * Adjustment for different chips + Update examples according to upstream + Code cleaning Rust format * Add record to the CHANGELOG * Code cleaning, getting rid of useless generic argument Typo fix Fix fmt
At this point we have some issues connected with
esp32s3chip, corresponding issue will be created.