-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sleep support for esp32c3 #795
Conversation
Thanks for the PR. Could you please remove all of the |
(Also sorry, I will review this soon!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for your contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have apprehensions about having completely different RTCPin
traits for RISC-V and Xtensa, but I think for the time being this is okay and probably implies we need to rethink that trait. Once we add support for more devices the path forward may become more clear, so we'll just roll with this for now I suppose.
Thanks for your work on this, LGTM!
This implements basic support for esp32c3 sleep. Only timer and GPIO are supported for wakeup so far.
I wrote this mostly by comparing the esp32s3 sleep implementation with the IDF source. I was a little confused by the
RTCPinWithResistor
trait, because as far as I could tell IDF configures pullup and pulldown on all the wakeup pins...I had one question, though (which is probably caused by me being an embedded noob): what do you do to observe printlns when sleeping?
espflash
seems to just disconnect on deep sleep, and on light sleep it keeps the connection but doesn't actually print anything. I'm testing it right now using blinking leds...Must
errors
orwarnings
.cargo fmt
was run.CHANGELOG.md
in the proper section.Nice to have