-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the radio
module with peripheral singleton structs
#852
Conversation
I think I like this better and also it probably makes things easier. But looking at it I was wondering if - given those are just virtual peripherals - we could just define up to three virtual peripherals like Wifi, Bluetooth and Ieee802154 independently. Would probably make things even easier but not sure if that would have any disadvantages (I guess not) |
I like that idea too, I don't think there is any downside to it because there is currently no situation where we don't call |
Ahh yeah that seems obvious in hindsight haha, thanks for the suggestions. Will update this PR. |
e94e49a
to
975322f
Compare
radio
module, eliminate the RadioExt
traitradio
module with peripheral singleton structs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Just some quick cleanup:
RadioExt
traitRADIO
is a virtual peripheral it's already defined in this package, and we don't need an extension trait