Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted analog-related simplifications/clean up #857

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Assorted analog-related simplifications/clean up #857

merged 4 commits into from
Oct 19, 2023

Conversation

jessebraham
Copy link
Member

Just some small changes, cleaning things up a bit. Part of my prelude-simplification-yak-shaving adventure (more fun to come!).

  • Remove the analog modules from the chip-specific HAL packages
    • Not sure why these existed in the first place? Historical reasons? Regardless, not necessary
  • Merge the SarAdcExt and SensExt traits into a single AnalogExt trait
    • There was no reason for these to be different traits
  • A bit of clean up and simplification in the analog module

bjoernQ
bjoernQ approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MabezDev MabezDev merged commit 4238a63 into esp-rs:main Oct 19, 2023
17 checks passed
@jessebraham jessebraham deleted the fixes/analog branch October 19, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@MabezDev MabezDev Awaiting requested review from MabezDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessebraham @bjoernQ @MabezDev