Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gate the embedded-io trait impls behind a feature #964

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Gate the embedded-io trait impls behind a feature #964

merged 2 commits into from
Nov 20, 2023

Conversation

jessebraham
Copy link
Member

Should have been this way from the start, was my mistake.

I've enabled the embedded-io feature via the async feature as well, as trying to get the Error and ErrorType traits implemented was pretty frustrating otherwise. I think this is reasonable.

MabezDev
MabezDev approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! embedded-io-async depends on embedded-io internally anyways, so it makes sense to enable both in the async case

@MabezDev MabezDev added this pull request to the merge queue Nov 20, 2023
Merged via the queue into esp-rs:main with commit 8754217 Nov 20, 2023
17 checks passed
@jessebraham jessebraham deleted the fixes/embedded-io branch November 20, 2023 15:04
@jessebraham jessebraham mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessebraham @MabezDev