Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i2c - async write_read in parallel #979

Closed
wants to merge 1 commit into from

Conversation

elpiel
Copy link
Contributor

@elpiel elpiel commented Nov 27, 2023

Attempt at parallelising the write_read I2C async fn implementation.

  • There might be a need for a join-style async fn wait_for_completion that will wait for both operations to finish, instead of select-ing one or the other

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

@jessebraham jessebraham added the skip-changelog No changelog modification needed label Dec 1, 2023
@jessebraham
Copy link
Member

Thanks for the PR, I'll do my best to get to this next week!

@MabezDev
Copy link
Member

What's the status here? Can we move this along somehow?

@elpiel
Copy link
Contributor Author

elpiel commented Jan 24, 2024

I would suggest someone to pick up this branch/issue and continue it.
I have switched to a different platform for the time being and don't think I'm going back to the issue any time soon.

It still needs a few fixes I suppose and to be tested

@elpiel
Copy link
Contributor Author

elpiel commented Jan 29, 2024

@jessebraham where/how was this fixed?
Can you provide a link?

@jessebraham
Copy link
Member

It wasn't fixed yet, you said you were not going to work on it anymore so I closed the PR. I was planning on looking into it this or next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants