Add EspNetif::set_ip_info #398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkleyy
force-pushed
the
set-ip-pr
branch
3 times, most recently
from
cf40c85
to
e3b919f
Compare
|
Probably we will also need a method to reenable DHCP. |
|
Limited access to internet right now. Will follow up when I have an opportunity |
|
Sure, there's no rush. |
|
from the issue conversation ivmarkov thought that it may be problematic to update such values when the netif is in the up state, But you thought based on the docu that it still should work. So you can confirm that calling esp_netif_set_ip_info does not produce sideeffects / e.g its save to be callable in any state? |
|
I haven't tested this much as we follow a different approach atm. In any case there is no way to reenable DHCP with just this method added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #332