-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI to build all the targets #35
Conversation
@@ -63,8 +63,11 @@ jobs: | |||
board: ['esp32', 'esp32s2', 'esp32s3', 'esp32c3'] | |||
std: ['true', 'false'] | |||
steps: | |||
- name: Setup | cargo-generate | |||
run: cargo install cargo-generate | |||
- name: Install cargo-generate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this and not just cargo install cargo-generate
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed to the binary approach as it's way faster. If you think is better to do it with cargo install
I am happy to undo this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why we are now installing cargo-generate that way?
It's only because it's faster, but I wouldn't mind using |
Installing |
@SergioGasquez Sorry for following up late, can you resolve the conflicts, then I'll merge? |
Hello @ivmarkov, do not worry about the delays! Conflicts are now resolved. Thanks for all your dedication! |
@SergioGasquez I think we need to temporarily disable the PlatformIO based build, until we figure out what is wrong there. |
I've commented those steps! |
@SergioGasquez BTW it still complains that the branch is unmergeable due to conflicts. |
It now shows that it can be merged with no conflicts! :) |
It can be merged but it cannot be rebased. Anyway, ill not use rebase then. |
Expanded the CI to build the project for all the targets using the Dockerfile generated for devcontainer support.