Multiple TcpSockets share the same static mut buffers

[IsaacDynamo]

In function create_network_interface() from src/wifi/utils.rs

    for _ in 0..sockets_to_add {
        let rx_tx_socket1 = {
            static mut TCP_SERVER_RX_DATA: [u8; 1536] = [0; 1536];
            static mut TCP_SERVER_TX_DATA: [u8; 1536] = [0; 1536];

            let tcp_rx_buffer = unsafe { TcpSocketBuffer::new(&mut TCP_SERVER_RX_DATA[..]) };
            let tcp_tx_buffer = unsafe { TcpSocketBuffer::new(&mut TCP_SERVER_TX_DATA[..]) };

            TcpSocket::new(tcp_rx_buffer, tcp_tx_buffer)
        };
        ethernet.add_socket(rx_tx_socket1);
    }

When sockets_to_add is more than one, the static mutable variables TCP_SERVER_RX_DATA and TCP_SERVER_TX_DATA are used multiple times to create multiple TcpSocket's.

This will result in multiple mutable references to the same buffer which is unsound.

And as a consequence data is corrupted when multiple sockets are used at the same time.

[bjoernQ]

Thanks for reporting this! This should get changed, certainly.

In the meantime, it's possible to not use the utils and do the initialization manually.