Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple sockets, UDP and multicast #82

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Nov 18, 2022

Fixes #76

  • add support for UDP sockets
  • add support for multicast groups
  • update dependencies

@ImUrX
Copy link
Contributor

ImUrX commented Nov 19, 2022

when is this getting merged, i really need the updated dependencies xD

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Nov 21, 2022

hopefully it will get reviewed and merged later today - we really want to have every small change smoke-tested at least

but since this crate is currently only available via a git dependency you can also temporarily just use the fork/branch - but it should get it today anyways

@ImUrX ImUrX mentioned this pull request Nov 22, 2022
@bjoernQ
Copy link
Contributor Author

bjoernQ commented Nov 22, 2022

@jessebraham Mind testing the examples on all the supported targets with your setup? I don't expect problems but would be good to double check this

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working for all examples on my network. The ESP32-S2 seems to be incredibly slow and often hangs on Wait to get an ip address, but I think that may have already been the case, I can't recall.

@bjoernQ bjoernQ merged commit 5c66422 into main Nov 22, 2022
@bjoernQ bjoernQ deleted the feature/udp-utils branch December 16, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple TcpSockets share the same static mut buffers
3 participants