-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defmt related improvements #255
Conversation
4cd89e0
to
a372611
Compare
97b4ac4
to
cd5b960
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry @bugadani, can you switch back to the now-released crates.io versions for the hals? 😅 |
Yup, I did it, otherwise users can't mix release versions of esp-hal with git versions of esp-wifi. Oops, good call, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @bugadani ! Once CI finishes I'll merge this!
@MabezDev if I may bug you, the CI did finish ;) |
In this PR:
blocked on the next esp-hal releaseI've followed the beaten path of version-and-git-repo dependencies