Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defmt related improvements #255

Merged
merged 6 commits into from
Sep 5, 2023
Merged

defmt related improvements #255

merged 6 commits into from
Sep 5, 2023

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Sep 1, 2023

In this PR:

  • I've replaced my macros with the solution pasted from embassy. This means less use statements.
  • I've updated CI to not activate both log and defmt at the same time
  • Enabling log or defmt now enables the same feature for esp-hal
  • I've matrixified CI to deduplicate the lists of examples
  • ... probably something else I forgot

blocked on the next esp-hal release I've followed the beaten path of version-and-git-repo dependencies

@bugadani bugadani force-pushed the defmtfix branch 26 times, most recently from 4cd89e0 to a372611 Compare September 5, 2023 07:45
@bugadani bugadani marked this pull request as ready for review September 5, 2023 07:46
@bugadani bugadani force-pushed the defmtfix branch 2 times, most recently from 97b4ac4 to cd5b960 Compare September 5, 2023 07:51
@bugadani
Copy link
Contributor Author

bugadani commented Sep 5, 2023

@bjoernQ @MabezDev after tons of back-and-forth, this should be ready for your attention.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MabezDev
Copy link
Member

MabezDev commented Sep 5, 2023

Sorry @bugadani, can you switch back to the now-released crates.io versions for the hals? 😅

@bugadani
Copy link
Contributor Author

bugadani commented Sep 5, 2023

@MabezDev I can remove the ref =-s if it makes a difference (though I'm quite sure they would be readded at some point anyway) but the versions are already the new ones.

Yup, I did it, otherwise users can't mix release versions of esp-hal with git versions of esp-wifi. Oops, good call, thanks!

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bugadani ! Once CI finishes I'll merge this!

@bugadani
Copy link
Contributor Author

bugadani commented Sep 5, 2023

@MabezDev if I may bug you, the CI did finish ;)

@MabezDev MabezDev merged commit 15e5a55 into esp-rs:main Sep 5, 2023
7 checks passed
@bugadani bugadani deleted the defmtfix branch September 6, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants