Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI argument structs are not marked #[non_exhaustive] #473

Closed
1 task
jessebraham opened this issue Sep 14, 2023 · 1 comment · Fixed by #517
Closed
1 task

CLI argument structs are not marked #[non_exhaustive] #473

jessebraham opened this issue Sep 14, 2023 · 1 comment · Fixed by #517
Labels
bug Something isn't working status:longterm This task will be around a while
Milestone

Comments

@jessebraham
Copy link
Member

jessebraham commented Sep 14, 2023

This was an incredibly unfortunately oversight which was resulted in us needing to duplicate pretty much any new options between cargo-espflash and espflash. Fixing this is a semver-incompatible change so this will need to happen as part of the v3 release, whenever that happens.

Perhaps another option would be to simply not provide semver guarantees for anything in the cli module (it is feature gated after all, and is only really useful for the binary application).

Tasks

@jessebraham jessebraham added bug Something isn't working status:longterm This task will be around a while labels Sep 14, 2023
@jessebraham jessebraham added this to the v3 milestone Sep 14, 2023
@SergioGasquez
Copy link
Member

Perhaps another option would be to simply not provide semver guarantees for anything in the cli module (it is feature gated after all, and is only really useful for the binary application).

As we discussed, we should probably go for this, hence it needs to be documented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status:longterm This task will be around a while
Projects
Archived in project
2 participants