Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark cli args as non_exhaustive and warn that cli mod doesnt provide SemVer guarantees. #517

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Mark cli args as non_exhaustive and warn that cli mod doesnt provide SemVer guarantees. #517

merged 3 commits into from
Dec 21, 2023

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Nov 22, 2023 •
edited
Loading

  • Add warnings that cli mod does not provide SemVer guarantees
  • Mark cli args as non_exhaustive

@SergioGasquez SergioGasquez linked an issue Nov 22, 2023 that may be closed by this pull request
CLI argument structs are not marked #[non_exhaustive] #473
Closed
bjoernQ
bjoernQ approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pretty much straight forward. At first, I thought why not make the cli module non-public ... but yes - there is still cargo-espflash

@SergioGasquez SergioGasquez merged commit 2665054 into esp-rs:main Dec 21, 2023
19 checks passed
@SergioGasquez SergioGasquez deleted the feat/non-exh branch December 21, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@jessebraham jessebraham Awaiting requested review from jessebraham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI argument structs are not marked #[non_exhaustive]
2 participants
@SergioGasquez @bjoernQ