Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently support binary partition tables #212

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Consistently support binary partition tables #212

merged 2 commits into from
Jul 27, 2022

Conversation

kyrias
Copy link
Contributor

@kyrias kyrias commented Jul 27, 2022

Fixes #211.

@kyrias
Move parsing either CSV or binary partition table into own associated…
81f657d 
… function

Since this is done in multiple places it makes sense for PartitionTable
to just offer this as an associated function.
@kyrias
Make save-image able to use binary partition tables
73f4505 
Fixes esp-rs#211
jessebraham
jessebraham approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@jessebraham jessebraham merged commit e67667b into esp-rs:master Jul 27, 2022
@kyrias kyrias deleted the consistently-support-binary-partition-tables branch July 27, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to open partition table when using save-image with esp-idf custom partition table
2 participants
@kyrias @jessebraham