Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Interface constructor public #354

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Make Interface constructor public #354

merged 1 commit into from
Feb 15, 2023

Conversation

bugadani
Copy link
Contributor

As it turns out, users (me) might actually want to construct Interface objects. While the fields are public, the raspberry-enabled new does a few useful things that I don't necessarily want to duplicate in my program.

jessebraham
jessebraham approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough, I think it was only protected because the interface module at one point was private, so this probably just never got updated. Thanks!

@jessebraham jessebraham merged commit 4665742 into esp-rs:main Feb 15, 2023
@bugadani bugadani deleted the interface branch February 15, 2023 15:43
@bugadani
Copy link
Contributor Author

I missed it, too, when I was poking at raspberry support :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bugadani @jessebraham