Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable watchdog timer before build. #363

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Disable watchdog timer before build. #363

merged 4 commits into from
Mar 24, 2023

Conversation

jnross
Copy link
Contributor

@jnross jnross commented Mar 6, 2023

Fixes #361

@jnross
Copy link
Contributor Author

jnross commented Mar 9, 2023

Sorry I forgot to double-check that I ran rustfmt before pushing. Turns out there was a stray newline. I've run rustfmt and pushed another commit with the fixes.

@jnross jnross mentioned this pull request Mar 15, 2023
Closed
@jnross jnross force-pushed the joe/disable-watchdog-before-build branch from 74f73af to c322124 Compare March 15, 2023 15:43
jessebraham
jessebraham approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to get to this, but LGTM! Thanks for fixing this!

@jessebraham jessebraham merged commit e120913 into esp-rs:main Mar 24, 2023
@jnross
Copy link
Contributor Author

jnross commented Mar 24, 2023

Thanks for considering and landing this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cargo-espflash fails to flash when the build is too long
2 participants
@jnross @jessebraham