-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation #368
Update documentation #368
Conversation
Sorry, still haven't gotten around to going through all these changes. Curious though, in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small change I'd like to see, plus the question I asked in the previous comment. Overall looks pretty good to me though, thanks for taking care of this!
Also looks like I've made some changes which have caused conflicts here, so this will need a rebase. Sorry about that, I'll hold off on my other PR fiddling with the |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those requested changes. Regarding the formatting stuff, I'm not too concerned out about it, just was curious. It's fine to just leave it as is, not worth the effort to change it back.
Thanks again for taking care of this!
too_many_arguments
lint is allowed)