Make the default flashing frequency target specific

[SergioGasquez]

I've implemented the third solution proposed by @maxwase in #375:

• Add flash_freq to Esp32Params so we can define a default flashing frequency per target.
• Specify the default flashing frequency for all the targets.

[maxwase]

Personally, I think FlashFrequency::default() usage is better (as in esp8266 module) and more future-proof (if this code will ever be refactored to use ..Esp32Params::default()), but it's up to decide :)

[SergioGasquez]

I've browsed the changes on my phone and I can't really understand your suggestion, do you mind elaborating? I'm any casi, tomorrow morning I will have a better look at it! Thanks for the feedback!

…

On Mon, Apr 17, 2023, 20:32 Max Wase ***@***.***> wrote: ***@***.**** commented on this pull request. Personally, I think FlashFrequency::default() usage is better (as in esp8266 module) and more future-proof (if this code will ever be refactored to use ..Esp32Params::default()), but it's up to decide :) — Reply to this email directly, view it on GitHub <#389 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADCTYYK4VCNOW6RCMHGZON3XBWED3ANCNFSM6AAAAAAXBBB32E> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[maxwase]

Oh, sorry for unclarity 😄, I mean replacing of FlashFrequency::_40Mhz with FlashFrequency::default() as it is a default frequency

[SergioGasquez]

Oh, sorry for unclarity smile, I mean replacing of FlashFrequency::_40Mhz with FlashFrequency::default() as it is a default frequency

Ahh! I've tried this yesterday, but since PARAMS is a const, it fails:

`~const std::default::Default` is not implemented for `FlashFrequency`

And I don't know/couldn't find any easy solution to this

[maxwase]

Oh, sorry for unclarity smile, I mean replacing of FlashFrequency::_40Mhz with FlashFrequency::default() as it is a default frequency

Ahh! I've tried this yesterday, but since PARAMS is a const, it fails:

`~const std::default::Default` is not implemented for `FlashFrequency`

And I don't know/couldn't find any easy solution to this

Oh, didn't spot that, hope we will get it someday! Other than that, LGTM

[jessebraham]

LGTM, thanks for fixing this!