Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a diagnostic to tell the user about the partition table format #397

Merged
merged 1 commit into from
May 4, 2023

Conversation

MabezDev
Copy link
Member

@MabezDev MabezDev commented May 3, 2023

When the image doesn't fit.

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just fyi, miette supports a url param under #[diagnostic], see https://github.com/zkat/miette#-diagnostic-code-urls

@MabezDev MabezDev force-pushed the diagnostic/link-to-partition-table-info branch from d854cd3 to d33e6a1 Compare May 4, 2023 10:37
@MabezDev
Copy link
Member Author

MabezDev commented May 4, 2023

Just fyi, miette supports a url param under #[diagnostic], see https://github.com/zkat/miette#-diagnostic-code-urls

Thanks! I didn't know about that, I've updated the diagnostic to use the URL feature.

@MabezDev MabezDev mentioned this pull request May 4, 2023
@MabezDev MabezDev merged commit 6d52193 into main May 4, 2023
@@ -44,6 +44,11 @@ pub enum Error {
#[error(
"Supplied ELF image of {0}B is too big, and doesn't fit configured app partition of {1}B"
)]
#[diagnostic(
code(espflash::image_too_big),
help("Reduce the size of the binary or increase the size of the partition."),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have preferred this to say "increase the size of the app partition", as it's pretty ambiguous now. Will fix it in another PR before release I guess.

MabezDev added a commit that referenced this pull request May 5, 2023
@MabezDev MabezDev mentioned this pull request May 5, 2023
jessebraham pushed a commit that referenced this pull request May 5, 2023
@jessebraham jessebraham deleted the diagnostic/link-to-partition-table-info branch July 13, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants