Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of serial ports on BSD systems #415

Merged
merged 1 commit into from
May 31, 2023

Conversation

jessebraham
Copy link
Member

@tingox would you mind verifying this fixes the issue for you, please?

Closes #409

@tingox
Copy link

tingox commented May 30, 2023

I do not mind at all:

tingo@kg-core1:~/personal/projects/2023/rust/embedded/esp/espflash $ target/release/espflash board-info
[2023-05-30T20:16:56Z INFO ] Detected 2 serial ports
[2023-05-30T20:16:56Z INFO ] Ports which match a known common dev board are highlighted
[2023-05-30T20:16:56Z INFO ] Please select a port
[2023-05-30T20:17:00Z INFO ] Serial port: '/dev/cuaU0'
[2023-05-30T20:17:00Z INFO ] Connecting...
[2023-05-30T20:17:04Z INFO ] Unable to connect, retrying with extra delay...
[2023-05-30T20:17:05Z INFO ] Using flash stub
Chip type:         esp32c3 (revision v0.3)
Crystal frequency: 40MHz
Flash size:        4MB
Features:          WiFi, BLE
MAC address:       58:cf:79:05:5c:e8
tingo@kg-core1:~/personal/projects/2023/rust/embedded/esp/espflash $ target/release/espflash board-info --port /dev/cuaU0
[2023-05-30T20:17:21Z INFO ] Serial port: '/dev/cuaU0'
[2023-05-30T20:17:21Z INFO ] Connecting...
[2023-05-30T20:17:25Z INFO ] Unable to connect, retrying with extra delay...
[2023-05-30T20:17:25Z INFO ] Using flash stub
Chip type:         esp32c3 (revision v0.3)
Crystal frequency: 40MHz
Flash size:        4MB
Features:          WiFi, BLE
MAC address:       58:cf:79:05:5c:e8

yes, this fixes the issue.

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jessebraham jessebraham merged commit d9f8f8b into esp-rs:main May 31, 2023
@jessebraham jessebraham deleted the fixes/bsd branch May 31, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

espflash thinks that dev/cuau0 and /dev/cuaU0 are the same (usb) serial port
4 participants