Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reset strategies #487

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Oct 6, 2023

PR based on @jessebraham work in #344, I didn't rebase because there were a lot of conflicts and wanted to manually review the changes while comparing them with esptool.

There are only some small differences:

Related issues/PRs: #349, #344, #323, #394, #387

Maybe related: #442, #450

Draft PR until some affected user can verify that it's working @georgik did some testing and confirmed that it's working!

@SergioGasquez SergioGasquez added this to the v3 milestone Oct 9, 2023
@SergioGasquez SergioGasquez marked this pull request as draft November 2, 2023 16:26
@SergioGasquez SergioGasquez force-pushed the fix/resets branch 2 times, most recently from e3822b1 to 322f5a9 Compare November 2, 2023 18:08
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long to get resolved, I think everything looks good here. Any further nitpicks/required fixes can be handled in the future as needed.

Thanks for taking care of this!

@jessebraham jessebraham merged commit 2c7ee4c into esp-rs:main Nov 16, 2023
20 of 38 checks passed
@SergioGasquez SergioGasquez deleted the fix/resets branch November 16, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants