Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add publish to crates.io job #492

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Add publish to crates.io job #492

merged 1 commit into from
Oct 17, 2023

Conversation

SergioGasquez
Copy link
Member

No description provided.

@SergioGasquez SergioGasquez mentioned this pull request Oct 17, 2023
Closed
@SergioGasquez SergioGasquez linked an issue Oct 17, 2023 that may be closed by this pull request
Add publishing to crates.io into the releases workflow #485
Closed
jessebraham
jessebraham approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Have we set the CARGO_API_KEY secret yet, or does that still need to be done?

@SergioGasquez
Copy link
Member Author

LGTM! Have we set the CARGO_API_KEY secret yet, or does that still need to be done?

Just added the secret!

@jessebraham jessebraham merged commit 54c8915 into esp-rs:main Oct 17, 2023
@SergioGasquez SergioGasquez deleted the feat/add-cd branch October 17, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add publishing to crates.io into the releases workflow
2 participants
@SergioGasquez @jessebraham