Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update log-format flag and merge monitor methods #499

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Update log-format flag and merge monitor methods #499

merged 2 commits into from
Nov 15, 2023

Conversation

SergioGasquez
Copy link
Member

  • The flag f was already being used by flash-freq, updated log-format to use L
  • Since the PR was intended to be released in a minor version, we created monitor_with method to avoid changing monitor, now it can be modified

@SergioGasquez SergioGasquez linked an issue Nov 6, 2023 that may be closed by this pull request
The -f flag is used for both flash_freq and log_format, triggering a debug_assertion in clap. #498
Closed
@SergioGasquez SergioGasquez mentioned this pull request Nov 6, 2023
Merged
jessebraham
jessebraham approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham merged commit 2e73c4f into esp-rs:main Nov 15, 2023
19 checks passed
@SergioGasquez SergioGasquez deleted the fix/f-flag branch November 16, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The -f flag is used for both flash_freq and log_format, triggering a debug_assertion in clap.
2 participants
@SergioGasquez @jessebraham