Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -c/--chip argument #514

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Add -c/--chip argument #514

merged 3 commits into from
Nov 21, 2023

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Nov 20, 2023 •
edited
Loading

When trying to build a C6 with and passing the --chip esp32h2 arg:

espflash/espflash on  feat/chip-arg [!?] is 📦 v3.0.0-dev via 🦀 v1.76.0-nightly took 7s 
❯ cargo r -r -- flash --monitor --chip esp32h2 esp32h2-app
   Compiling espflash v3.0.0-dev (/home/sergio/Documents/Espressif/forks/espflash/espflash)
    Finished release [optimized] target(s) in 6.84s
     Running `/home/sergio/Documents/Espressif/forks/espflash/target/release/espflash flash --monitor --chip esp32h2 esp32h2`
[2023-11-20T14:16:55Z INFO ] Serial port: '/dev/ttyUSB0'
[2023-11-20T14:16:55Z INFO ] Connecting...
Error: espflash::chip_missmatch

  × Chip provided (esp32h2) with `-c/--chip` does not match the detected chip (esp32c6)
  help: Ensure that the correct chip is selected, or remove the `-c/--chip` option to autodetect the chip

@SergioGasquez SergioGasquez linked an issue Nov 20, 2023 that may be closed by this pull request
Add an optional --chip argument to the flash and write-bin subcommands #475
Closed
jessebraham
jessebraham approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham merged commit 505b98c into esp-rs:main Nov 21, 2023
19 checks passed
@SergioGasquez SergioGasquez deleted the feat/chip-arg branch November 21, 2023 11:29
@SergioGasquez SergioGasquez self-assigned this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees

@SergioGasquez SergioGasquez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an optional --chip argument to the flash and write-bin subcommands
2 participants
@SergioGasquez @jessebraham