Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for custom partition table offsets #516

Merged
merged 6 commits into from
Nov 22, 2023

Conversation

thetek42
Copy link
Contributor

@thetek42 thetek42 commented Nov 21, 2023

  • Add a --partition-table-offset flag that corresponds to esp-idf's CONFIG_PARTITION_TABLE_OFFSET
    • If the flag is specified, the partition table will be flashed to the given location.
    • If the flag is omitted, the partition table location will be determined automatically from the partition table by subtracting 0x1000 from the first partition, which should be the most common case.
  • The location of the application is now automatically determined from the partition table instead of the hard-coded 0x10000.

Closes #458

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham merged commit d886d33 into esp-rs:main Nov 22, 2023
19 checks passed
@thetek42 thetek42 deleted the flash-location branch November 22, 2023 09:34
@SergioGasquez SergioGasquez mentioned this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support flashing partition table at custom location
2 participants