Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement skip and verify #538

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Implement skip and verify #538

merged 3 commits into from
Dec 28, 2023

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Dec 28, 2023 •
edited
Loading

Implements verify, closes #259
Implements skip flashing of unchanged flash regions, closes #479

@bjoernQ bjoernQ marked this pull request as draft December 28, 2023 11:27
@bjoernQ bjoernQ marked this pull request as ready for review December 28, 2023 12:18
SergioGasquez
SergioGasquez approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested it a bit and re-flashing the same app is now way faster, thanks for the feature!

@SergioGasquez SergioGasquez merged commit cbdbcae into esp-rs:main Dec 28, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bjoernQ @SergioGasquez